- #36
pbuk
Science Advisor
Homework Helper
Gold Member
- 4,792
- 3,070
Well done, AWS is probably the least user-friendly of the cloud providers so that is a useful learning curve in itself! As always I have a few observations:deltapapazulu said:welp got it set up and secured thru AWS with a Custom Domain and HTTPS | S3, Route 53, CloudFront, Certificate Manager, etc. Definitely somewhat of a learning curve. Fortunately there are some good instruction videos available for it.
Your HTML is not valid:
- Your closing </head> tag must come after the <title> and <link> tags.
- Your closing </body> tag must come after all other tags (except </html>.
- You have a closing </br> tag: br is self closing.
- You also have a
You have clearly hand-crafted your CSS which has some advantages and some disadvantages. One big disadvantage is that it is harder to make sure your CSS works well on all browsers. For instance in this code (in which I have normalised the white space for easier reading):
CSS:
.delete-fields-btn {
margin-left: 55px;
margin-right: 30px;
color:blue;
width: 45px;
height: 35px;
font-size: 23px;
-webkit-border-radius: 5px;
box-shadow: 0 1px 2px #5e5d5b;
}
You have invalid CSS in line 174
color:#6f0007;"
. I am not sure what you are using to edit CSS but my VS Code editor highlights this, as well as the hanging webkit target mentioned above.You should leverage the cascading feature of CSS to avoid repeating yourself. For instance style all buttons with a
.btn
class and only add variations with .btn.delete-fields-btn
. Also instead of this:
HTML:
<ul id="id01" style="list-style: none;">
<li class="liN" style="cursor: pointer;" onclick="changeNoun(aciesargs)">aciēs</li>
HTML:
<ul id="id01">
<li onclick="changeNoun(aciesargs)">aciēs</li>
CSS:
ul#id01 {
list-style: none;
}
ul#id01 > li {
cursor: pointer; /* (this might work better on the parent ul anyway */
/* .. the rest of the .liN styles */
}
Create your data as a single object with the names as keys rather then individual global variables: we generally keep pollution of the global namespace to a minimum to avoid clashes.
Last edited: