So get the computer to step through the code one instruction at a time. You'll be able to see what's going on in the middle of program execution.phion said:
I don't know how!mfb said:
I couldn't tell you the answer to that, but it seems important.Ibix said:
Text processing is a pain because of details like this. It may or may not be relevant.phion said:
That could be the problem.TurtleMeister said:
The last item in the list is deleted because he substracts 1 from numPlayers in removePlayers, but the array itself is unchanged..phion said:
And specifically for an array passed "ByVal":
https://msdn.microsoft.com/en-us/library/eek064h4.aspx
That may be the case, but don't assume it, debug to make sure.phion said:
This makes sense. You don't touch your array in this modified code. Now this is not the whole removePlayer function. If your modified version still contains the updatedPlayers = numPlayers - 1 instruction, this will obviously make it appear as if the last name of the array is removed, as you won't reach it when you loop the array.phion said:
https://support.microsoft.com/en-us/kb/142999phion said:
Module Module1
Dim numPlayers As Integer
Dim playerListTmp As New Collection
Sub Main()
Dim playerList, tempPlayerList As New Collection()
numPlayers = loadList(playerList)
numPlayers = addPlayers(playerList, numPlayers)
displayList(playerList, numPlayers)
numPlayers = removePlayer(playerList, numPlayers)
displayList(playerList, numPlayers)
saveList(playerList, numPlayers)
Console.WriteLine("List saved successfully!")
End Sub
Function loadList(playerList As Collection
) As Integer
Dim fileName As String = "playerList.txt"
numPlayers = 0
If File.Exists(fileName) Then
Dim inFile As New StreamReader(fileName)
While Not inFile.EndOfStream
playerList.Add(inFile.ReadLine(), numPlayers)
numPlayers += 1
End While
inFile.Close()
Else
Console.WriteLine("Could Not Open " & fileName)
End If
Return numPlayers
End Function
Function addPlayers(playerList As Collection, numPlayers As Integer) As Integer
Dim newPlayer As String
Dim fileName As String = "playerList.txt"
Dim inFile As New StreamWriter(fileName, True)
Console.Write("Enter player name ('exit' to quit): ")
newPlayer = Console.ReadLine()
While newPlayer <> "exit"
inFile.WriteLine(newPlayer)
playerList.Add(newPlayer, numPlayers)
numPlayers += 1
Console.Write("Enter player name ('exit' to quit): ")
newPlayer = Console.ReadLine()
End While
inFile.Close()
Return numPlayers
End Function
Sub displayList(playerList As Collection, numPlayers As Integer)
Dim i As Integer
For i = 1 To numPlayers
Console.WriteLine("Player " & i & ": " & playerList.Item(i).ToString())
Next
End Sub
Function removePlayer(playerList As Collection, numPlayers As Integer) As Integer
Dim player As String
Dim fileName As String = "playerList.txt"
Dim tempFileName As String = "tempPlayerList.txt"
Dim inFile As New StreamReader(fileName)
Dim outFile As New StreamWriter(tempFileName)
Dim playerTmp As String
Dim count As Integer = 0
Console.WriteLine("Which player would you like to remove?")
player = Console.ReadLine() For i = 1 To numPlayers
playerTmp = inFile.ReadLine()
If player <> playerTmp Then
playerListTmp.Add(playerTmp, i)
outFile.WriteLine(playerTmp)
count += 1
End If
Next
inFile.Close()
outFile.Close()
File.Delete("playerList.txt")
My.Computer.FileSystem.RenameFile("tempPlayerList.txt", "playerList.txt")
File.Create("tempPlayerList.txt")
playerList.Clear()
For i = 1 To count
playerList.Add(playerListTmp.Item(i), i)
Next
Return count
End Function
Sub saveList(playerList As Collection, numPlayers As Integer)
Dim fileName As String = "playerList.txt"
Dim outFile As New StreamWriter(fileName)
For i = 1 To numPlayers
outFile.WriteLine(playerList(i))
Next
outFile.Close()
End SubEnd ModuleI'm sorry, I thought this was made clear. This code is for a VB console program designed to manipulate data, namely "wins," "losses," "skill," "name," etc. which are stored in both arrays and text files. The remove player function should modify the playerList text file, and the playerList array I suppose, so that a player specified by the user is removed from the list, as well as all of their other corresponding data stored in separate arrays. This way, when the user chooses the menu option to view records of all the players, the proper data is displayed.Samy_A said:
Do you see the ambiguity in your reply? "The remove player function should modify the playerList text file, and the playerList array I suppose".phion said:
Not really, no.phion said:
Yes, I am aware. You're probably pretty used to customers being frustratingly ambiguous I bet.Samy_A said:
No problem. Just try to be systematic in your work.phion said:Yes, I am aware. You're probably pretty used to customers being frustratingly ambiguous I bet.
I'm working on the others suggestions, but I do feel like keeping this thread alive in the process. Setting breakpoints is not something I have not yet done.
I appreciate the guidance.Samy_A said:
Yes, that is true. My post #42 is incorrect. ByVal only applies to value types. Arrays are reference types. And I guess it's a good thing because it would be pretty inefficient to copy an entire array and all it's elements every time you passed it as an argument.Samy_A said: